chore: drop TODOs earmarked for 2.0 that won't be done yet (#1607)

aspect-build · Apr 22, 2024 · 3c835e0 · 3c835e0
1 parent 5933403
commit 3c835e0
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/js/private/bash.bzl b/js/private/bash.bzl
@@ -1,8 +1,8 @@
 "Bash snippets for js rules"
 
-# TODO(2.0): Instead of setting a new RUNFILES env; just set RUNFILES_DIR if it is not set;
-#            needs testing to know if RUNFILES_DIR is set always set to the same value as RUNFILES
-#            when it is set.
+# TODO: Instead of setting a new RUNFILES env; just set RUNFILES_DIR if it is not set;
+#       needs testing to know if RUNFILES_DIR is set always set to the same value as RUNFILES
+#       when it is set.
 # Bash snipped to initialize the RUNFILES environment variable.
 # Depends on there being a logf_fatal function defined.
 # NB: If this can be generalized fully in the future and not depend on logf_fatal

diff --git a/js/private/js_binary.sh.tpl b/js/private/js_binary.sh.tpl
@@ -147,7 +147,6 @@ trap _exit EXIT
 # Initialize RUNFILES environment variable
 # ==============================================================================
 {{initialize_runfiles}}
-# TODO(2.0): export only JS_BINARY__RUNFILES
 export RUNFILES
 JS_BINARY__RUNFILES="$RUNFILES"
 export JS_BINARY__RUNFILES

diff --git a/js/private/test/snapshots/bzlmod/launcher.sh b/js/private/test/snapshots/bzlmod/launcher.sh
diff --git a/js/private/test/snapshots/wksp/launcher.sh b/js/private/test/snapshots/wksp/launcher.sh