Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: make unresolved_symlinks_enabled attribute of js_binary man…
Browse files Browse the repository at this point in the history
…datory (#1571)
gregmagolan committed May 7, 2024
1 parent 820da23 commit 3537a51
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/js_binary.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions js/private/js_binary.bzl
Original file line number Diff line number Diff line change
@@ -267,8 +267,7 @@ _ATTRS = {
attribute based on a `config_setting` rule.
See /js/private/BUILD.bazel in rules_js for an example.
""",
# TODO(2.0): make this mandatory so that downstream binary rules that inherit these attributes are required to set it
mandatory = False,
mandatory = True,
),
"node_toolchain": attr.label(
doc = """The Node.js toolchain to use for this target.

0 comments on commit 3537a51

Please sign in to comment.