chore: runfiles is now optional with rules_js

aspect-build · Jan 8, 2024 · 5a6dc30 · 5a6dc30
1 parent b9ae2ef
commit 5a6dc30
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 15 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -2,8 +2,6 @@
 # Take care to document any settings that you expect users to apply.
 # Settings that apply only to CI are in .github/workflows/ci.bazelrc
 
-# For rules_js
-build --enable_runfiles
 # Config to enable building and testing with bzlmod
 common:bzlmod --enable_bzlmod --@aspect_bazel_lib//lib:flag_bzlmod
 

diff --git a/MODULE.bazel b/MODULE.bazel
@@ -7,7 +7,7 @@ module(
 )
 
 bazel_dep(name = "aspect_bazel_lib", version = "1.39.1")
-bazel_dep(name = "aspect_rules_js", version = "1.34.1")
+bazel_dep(name = "aspect_rules_js", version = "1.35.0")
 bazel_dep(name = "bazel_skylib", version = "1.5.0")
 bazel_dep(name = "platforms", version = "0.0.8")
 bazel_dep(name = "rules_nodejs", version = "5.8.3")

diff --git a/e2e/bundle/.bazelrc b/e2e/bundle/.bazelrc
@@ -1,2 +1 @@
-build --enable_runfiles
 common:bzlmod --enable_bzlmod
diff --git a/e2e/npm-links/.bazelrc b/e2e/npm-links/.bazelrc
@@ -1,2 +1 @@
-build --enable_runfiles
 common:bzlmod --enable_bzlmod
diff --git a/e2e/npm-links/MODULE.bazel b/e2e/npm-links/MODULE.bazel
@@ -1,7 +1,7 @@
 "Bazel dependencies"
 
 bazel_dep(name = "aspect_rules_esbuild", version = "0.0.0", dev_dependency = True)
-bazel_dep(name = "aspect_rules_js", version = "1.34.1", dev_dependency = True)
+bazel_dep(name = "aspect_rules_js", version = "1.35.0", dev_dependency = True)
 bazel_dep(name = "bazel_skylib", version = "1.5.0", dev_dependency = True)
 
 local_path_override(

diff --git a/e2e/smoke/.bazelrc b/e2e/smoke/.bazelrc
@@ -1,2 +1 @@
-build --enable_runfiles
 common:bzlmod --enable_bzlmod
diff --git a/e2e/sourcemaps/.bazelrc b/e2e/sourcemaps/.bazelrc
@@ -1,2 +1 @@
-build --enable_runfiles
 common:bzlmod --enable_bzlmod
diff --git a/e2e/tsconfig/.bazelrc b/e2e/tsconfig/.bazelrc
@@ -1,2 +1 @@
-build --enable_runfiles
 common:bzlmod --enable_bzlmod
diff --git a/esbuild/dependencies.bzl b/esbuild/dependencies.bzl
@@ -21,9 +21,9 @@ def rules_esbuild_dependencies():
 
     http_archive(
         name = "aspect_rules_js",
-        sha256 = "76a04ef2120ee00231d85d1ff012ede23963733339ad8db81f590791a031f643",
-        strip_prefix = "rules_js-1.34.1",
-        url = "https://github.com/aspect-build/rules_js/releases/download/v1.34.1/rules_js-v1.34.1.tar.gz",
+        sha256 = "a2f941e27f02e84521c2d47fd530c66d57dd6d6e44b4a4f1496fe304851d8e48",
+        strip_prefix = "rules_js-1.35.0",
+        url = "https://github.com/aspect-build/rules_js/releases/download/v1.35.0/rules_js-v1.35.0.tar.gz",
     )
 
     http_archive(

diff --git a/internal_deps.bzl b/internal_deps.bzl
@@ -13,9 +13,9 @@ def rules_esbuild_internal_deps():
     # opt-in to 2.0 without forcing users to do so
     http_archive(
         name = "aspect_bazel_lib",
-        sha256 = "fc8bd670380eaba5314769abbe9fee21d641e3da06d9d26b8073a301f6d62332",
-        strip_prefix = "bazel-lib-2.1.0",
-        url = "https://github.com/aspect-build/bazel-lib/releases/download/v2.1.0/bazel-lib-v2.1.0.tar.gz",
+        sha256 = "a9ea6902c860918bd6928114efbc6ea2093df006af66459c9ac1637f9dd08f6a",
+        strip_prefix = "bazel-lib-2.1.2",
+        url = "https://github.com/aspect-build/bazel-lib/releases/download/v2.1.2/bazel-lib-v2.1.2.tar.gz",
     )
 
     http_archive(
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		build --enable_runfiles
		common:bzlmod --enable_bzlmod