Fix table rendering with terminals less than 90 chars #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No interesting changes, yet.
Previously, when the terminal was less than about 90 chars wide ratatui would shrink or even disappear one of the data columns, seemingly at random. This was a regression from tui, which would always shrink the final column. Now, ztop will always display a minimum of 6 chars for the Dataset column, and shrink a data column (again, at random) only for very narrow terminals. Fixes #32
asomers
force-pushed
the
ratatui-0.24.0
branch
from
f9febf6 to
e13b58f
Compare
asomers
added a commit
that referenced
this pull request
Dec 18, 2023
The bug that PR fixed was only introduced after the last release, so it doesn't need documentation in the CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix table rendering with terminals less than 90 chars
Previously, when the terminal was less than about 90 chars wide ratatui would shrink or even disappear one of the data columns, seemingly at random. This was a regression from tui, which would always shrink the final column.
Now, ztop will always display a minimum of 6 chars for the Dataset column, and shrink a data column (again, at random) only for very narrow terminals.
Fixes #32
Depends on ratatui/ratatui#660