Fixes according to: https://github.com/asmecher/lensGalley/issues/68 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withanage
requested changes
Nov 27, 2024
| // Perform variable replacement for journal, issue, site info | ||
| $issue = Repo::issue()->getBySubmissionId($galley->getData('submissionId')); | ||
| $issue = Repo::issue()->getBySubmissionId($galley->getData($submissionIdAux)); |
There was a problem hiding this comment.
@netmas
Can you confirm that this gets the file ?
$issue = Repo::issue()->getBySubmissionId($galley->getData($submissionIdAux));I could only get the file run using this modification ?
$issue = Repo::issue()->getBySubmissionId($submissionIdAux);There was a problem hiding this comment.
@netmas @Ppantaleo! sorry, I did not send a proper reivew reqest, please have a look about the comment and you may also need to check for the fileUrl for OJS 3.4
i locally had to use the follwing url to get it working.
$fileUrl = $request->url(null, 'article', 'download',[$referredArticle->getData('id'),'version',$referredPublication->getData('urlPath'), $galley->getBestGalleyId(), $embeddableFile->getId()]);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm working with Ppantaleo and proposed this fix: #68
All the details are there