Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only prune a branch if it exists #11

Merged
merged 1 commit into from
Apr 30, 2019
Merged

only prune a branch if it exists #11

merged 1 commit into from
Apr 30, 2019

Conversation

jstaehle
Copy link
Contributor

No description provided.

@jstaehle jstaehle requested a review from theQuazz April 30, 2019 17:05
theQuazz
theQuazz approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@theQuazz theQuazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which cases would we not have a task?

@jstaehle
Copy link
Contributor Author

This happens when we request to cleanup a qa environment that has already been torn down, e.g. when I reopen a pull request and ship the reopened one

@jstaehle
Copy link
Contributor Author

actually, even more generally it happens when we request to clean up a qa environment for a PR that never had a qa environment spun up.

@jstaehle jstaehle merged commit c5ca722 into master Apr 30, 2019
@jstaehle jstaehle deleted the feature/conditional-prune branch April 30, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theQuazz theQuazz theQuazz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstaehle @theQuazz