Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy command for windows #9

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

AbhinavOmprakash
Copy link
Contributor

This will pretty much add support for windows.

I tried lein uberjar and I could use shh as indicated. Creating, changing, and deleting a password work.

The only hitch is you have to run it with.
java -jar target/shh.jar
for some reason the snapshot.jar doesn't work but shh.jar does.

Although I think this hitch can be solved by creating an installer script for windows, what do you think?

`string/includes?` is used in `copy-password` to test for windows os.
The reason `includes?` is used over a
a simple equality test is because multiple strings like
"Windows 10" and "Windows 11" would have to be tested for.
`includes?` simplifies this
@AbhinavOmprakash
Copy link
Contributor Author

I almost forgot about graalvm. 🤦🏻‍♂️
I currently don't have it on my machine. But since the jar works on windows, I suppose the native image would work too.

Until a GitHub workflow is setup we can rely on the jar, and install that instead.

@askonomm
Copy link
Owner

I already have a Windows build set-up actually, if you check in the repo .github/workflows directory and in the _test.yml file, so with this merge I can run the windows build and you should get a nice .exe.

@askonomm askonomm merged commit 66053f4 into askonomm:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants