[DOCS] plugins.md: removed trailing comma from code example (lines 78 and 133).

[bmarchesini]

[DOCS] nit: removed trailing comma from code example (lines 78 and 133).

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  Bug fix

• What is the current behavior? (You can also link to an open issue here)
  The example will lead to an error, "," not consistent 78 & 133

• What is the new behavior (if this is a feature change)?
  The example will work

• Other information:

[askmike]

Thanks for the PR!

The example will lead to an error, "," not consistent 78 & 133

It won't lead to an error, javascript ignores trailing commas. That said, it would still be good to clean this up :)

Would you mind changing the commit message to be more descriptive? Update plugins.md doesn't help us much when we look into the git history. It would be great if you can do something like:

[DOCS] nit: removed trailing comma from code example.

You don't have to create a new PR. You can use either git commit --amend or a rebase to do this (after which you should force push). In your last PR I did this manually, but can you do it this time?

[bmarchesini]

Hi, I unfortunately created a branch for each PR and I don't understand how "rebase" or "amend" for a commit in these branches (the different patches). The documentation on the internet assumes that we are in the main branch and if I change the branch name to the patch name the commit in question does not appear. I managed to reverse what seems to be in my main branch but I can't find the concerned commits to change them :/
But I was able to change the title of my PRs to match the description required for the commits.
Have you any idea how can I do it?

[askmike]

So you have your own Gekko repo that includes all your changes here: https://github.com/bmarchesini/gekko All changes for specific PRs are in different branches, see here: https://github.com/bmarchesini/gekko/branches Unfortunately you cannot do this on github.com itself you have to rebase by first cloning your own repo to your computer and using git command line on your computer. Here is a guide from the bitcoin repo: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits (after that guide be sure to upload your changes to github.com by doing `git push --force`. A more detailed guide on renaming commits (via a rebase, or via --amend) is here: https://help.github.com/articles/changing-a-commit-message/ Keep in mind that all changes in a pull request on github are whatever is on your own branch in your own repo. if you commit or change things in your branch that will automatically update the pull request.

…

On Tue, Nov 6, 2018 at 5:10 PM bmarchesini ***@***.***> wrote: Hi, I unfortunately created a branch for each PR and I don't understand how "rebase" or "amend" for a commit in these branches. I search the documentation on the internet but I can't find the information I need. I managed to reverse what seems to be in my main branch but I can't find the concerned commits to change them :/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2635 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7MD8Zjvt98P7Na6kuDb7XeBfId1OP0ks5usVIQgaJpZM4YOpb6> .

-- PGP key at keybase.io/mikevanrossum <https://keybase.io/mikevanrossum/key.asc>

[bmarchesini]

Hi, I think everything's fine, can you confirm that?

[askmike]

Perfect! Thanks :)