Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add set_delimiter #66

Merged
merged 1 commit into from
Jun 21, 2023
Merged

add set_delimiter #66

merged 1 commit into from
Jun 21, 2023

Conversation

algomera
Copy link

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Jun 20, 2023

PR Summary

  • Added a new configuration option for CSV delimiter
    The configuration file livewire_csv.php now has a new option called 'set_delimiter' which allows users to set their preferred delimiter for CSV files. By default, it uses a comma ,.
  • Updated CSV interaction to use the new delimiter setting
    The file InteractsWithCsvFiles.php was updated to use the delimiter specified in the configuration file when working with CSV files, providing more flexibility for users with different delimiter preferences.

@askdkc
Copy link
Owner

askdkc commented Jun 20, 2023

@algomera

This is nice!

Could you also write a test for this?

For example, add a sample csv with different delimiter like ';' then check if it gets imported correctly.

@askdkc askdkc merged commit 0abbc1e into askdkc:main Jun 21, 2023
@askdkc
Copy link
Owner

askdkc commented Jun 21, 2023

@algomera

Never mind. I wrote tests for this.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants