Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import function target IDs #70

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Import function target IDs #70

merged 7 commits into from
Jun 13, 2024

Conversation

ashtonmeuser
Copy link
Owner

@ashtonmeuser ashtonmeuser commented Jun 13, 2024 •
edited
Loading

Use import function target Object IDs rather than references. Prevents issues related to freed objects.

Closes #69.

This also slightly refactors file names (godot-wasm.cpp → wasm.cpp) and tweaks imports to favour libraries (#include "..." → #include <...>).

Test cases added for:

  • Missing method on import function target
  • Instantiating a Wasm module with a previously-freed import function target
  • Calling an import function from a Wasm module after target has been freed

@ashtonmeuser ashtonmeuser merged commit 1ec8f3b into master Jun 13, 2024
ashtonmeuser added a commit that referenced this pull request Jun 13, 2024
@ashtonmeuser
Backport import function target IDs (#70)
5669511
@ashtonmeuser ashtonmeuser deleted the target-id branch June 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when import function target is freed
1 participant
@ashtonmeuser