-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop stripping mainFiles extension before build #89
Conversation
Thank you for your contribution. Unfortunately, the PR cannot be merged as is. This is because that the change breaks its compatibility with In https://github.com/James-Yu/LaTeX-Workshop , the suggested solution is to use project-specific configuration. AFAIK Atom is still developing the feature, so an alternative could be add a new placeholder. |
This reverts commit 0701259.
I had a quick glance at https://github.com/James-Yu/LaTeX-Workshop: LaTeX-Workshop strips only .tex extensions. I adopted their implementation. This way, compilation works for all filetypes, while bibtex is still broken for non-.tex files. Also I reverted the TikZ extension commit, as it can be discussed in it's own PR #90. |
Was just having a feeling of Déjà vu, wondering why the regex was there in the first place. By stripping only Wouldn't it better to introduce a new placeholder such that |
@ashthespy as James mentioned before, introducing a new placeholder would be a good solution. I was thinking of %DOC for the document with extension and %NAME for the document name without extension. Though, I like prefer it the way you propose it with %DOC and %EXT. |
Sounds like a good compromise right?
Should also handle the odd case that someone wants to get funky with a @simon123h would you be able to implement this or should I? Edit: I had a few minutes - It's done 👍 |
As of now, the extension of the main file is stripped before compilation. Thus,
example.tex
will result in a command likepdflatex example
.This works fine for
.tex
files, aspdflatex
will search for bothexample
andexample.tex
. However it fails at custom extensions, like.tikz
.This commit removes the stripping of the main files extension. So,
example.tikz
would be passed to pdflatex as it is.Related issue: #86