Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CSS, rename template #4

Closed

Conversation

pyrmont
Copy link

@pyrmont pyrmont commented Jun 19, 2019

Because of course I would do this.

@pyrmont
Copy link
Author

pyrmont commented Jun 21, 2019

So, what you think of this?

@ashmaroli
Copy link
Owner

I'm waiting for the verdict on the new formatter I proposed.
In current state, removing the borders and padding is not very aesthetically sound when accessing http://localhost:9292/perl?line_numbers=true&theme=monokai&juxtaposed=true

@ashmaroli
Copy link
Owner

Can the template be named lexer_juxtaposed instead?

@pyrmont
Copy link
Author

pyrmont commented Jul 9, 2019

@ashmaroli Done :)

@ashmaroli
Copy link
Owner

On using the latest upstream/master branch and testing http://localhost:9292/ruby?line_numbers=true&juxtaposed=true I see the following:
image

Notice how the tables are squashed into each other..
I think, I should reject this PR and try to reduce CSS in the base branch directly..
whatsay?

@pyrmont
Copy link
Author

pyrmont commented Jul 9, 2019

@ashmaroli Yep, that's cool with me!

@pyrmont pyrmont closed this Jul 9, 2019
@ashmaroli
Copy link
Owner

Thanks for understanding.

@pyrmont pyrmont deleted the prfix.pr-1168 branch January 8, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants