Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example of using tags command in README.md #465

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Update example of using tags command in README.md #465

merged 2 commits into from
Nov 11, 2022

Conversation

yipliu
Copy link
Contributor

@yipliu yipliu commented Nov 1, 2022

What does this PR do?

Fixes #464

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve
Copy link
Owner

ashleve commented Nov 10, 2022

@yipliu Thank you for the fix!

README.md Outdated Show resolved Hide resolved
@ashleve ashleve added the bug Something isn't working label Nov 10, 2022
Co-authored-by: Lukas <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Base: 84.70% // Head: 84.70% // No change to project coverage 👍

Coverage data is based on head (5941aa6) compared to base (cd640a0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files           9        9           
  Lines         353      353           
=======================================
  Hits          299      299           
  Misses         54       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashleve ashleve merged commit 6f8ab63 into ashleve:main Nov 11, 2022
@ashleve ashleve changed the title Update Use tags in readme Update example of using tags command in README.md Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug for some tags cases with hydra parse
3 participants