Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PinnedTaskSectionを実装した #2

Merged
merged 2 commits into from
Dec 8, 2023
Merged

PinnedTaskSectionを実装した #2

merged 2 commits into from
Dec 8, 2023

Conversation

st20089ki
Copy link
Contributor

@st20089ki st20089ki added the ✨ feature Implementation of new features. label Oct 24, 2023
@st20089ki st20089ki requested review from Sigumaa and dino3616 October 24, 2023 08:50
@st20089ki st20089ki self-assigned this Oct 24, 2023
@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lockerai-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:11am

dino3616
dino3616 requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@dino3616 dino3616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マークアップに関しては満点なのでサジェストはなしす^〜
ただパフォーマンスなり設計なりの観点からの MUST サジェスチョンがいくつかあるので対応していただけると 🙏
(OPTION が付いてるやつは文字通り修正しても修正しなくてもええでなやつなので、余裕があればでおkす)

apps/website/src/module/dashboard/ui/page/pinned-task-section/pinned-task-section.presenter.tsx Outdated Show resolved Hide resolved
apps/website/src/module/dashboard/ui/page/pinned-task-section/pinned-task-section.presenter.tsx Outdated Show resolved Hide resolved
apps/website/src/module/dashboard/ui/page/pinned-task-section/pinned-task-section.presenter.tsx Outdated Show resolved Hide resolved
apps/website/src/module/dashboard/ui/page/pinned-task-section/pinned-task-section.presenter.tsx Outdated Show resolved Hide resolved
@st20089ki st20089ki requested a review from dino3616 December 8, 2023 05:11
dino3616
dino3616 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@dino3616 dino3616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいんじゃね :)

Sigumaa
Sigumaa approved these changes Dec 8, 2023
View reviewed changes
Copy link

@Sigumaa Sigumaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM^_^

@st20089ki st20089ki merged commit ef9250c into main Dec 8, 2023
18 checks passed
@dino3616 dino3616 deleted the 1/PinnedTask branch December 8, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sigumaa Sigumaa Sigumaa approved these changes

@dino3616 dino3616 dino3616 approved these changes

Assignees

@st20089ki st20089ki

Labels
✨ feature Implementation of new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PinnedTaskSectionを実装する
3 participants
@st20089ki @Sigumaa @dino3616