Update sse4_crc32 to 3.0.0 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not entirely sure about this PR. As sse4_crc32 3.0.0 has implemented software fallback already. You could use sse4_crc32 directly without this wrapper. |
|
Okey doke! Thanks. |
|
@ryanseys I've tested new version of sse4_crc32, which could give false negative test result on CPU feature detection. I've already filed a bug with @anandsuresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help us out in
gcloud-nodefix a hardware exception insse4_crc32that is fixed in 3.0.0.Related issues:
Thanks! 😄