Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure excluded config exists #37

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

klaaspieter
Copy link
Contributor

This ensures we don't attempt to call map on nil when swiftlint is
configured with an empty excluded key.

For example our swiftlint.yml has this:

excluded:
included:
  - folder

Which would make the plugin crash because excluded came in as nil. Since this is valid yml and swiftlint deals with it correctly I think danger-swiftlint should too.

This ensures we don't attempt to call map on nil when swiftlint is
configured with an empty excluded key.
Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@ashfurrow ashfurrow merged commit eed2dc7 into ashfurrow:master Apr 19, 2017
@klaaspieter klaaspieter deleted the empty-excluded branch April 19, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants