Define Display as c_void instead of *mut c_void to match Xlib
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
approved these changes
May 6, 2023
MarijnS95
force-pushed
the
platform-types-display-match-xlib
branch
from
3d1f687 to
6605992
Compare
Xlib defines `Display` as follows:
typedef struct _XDisplay Display;
And then always references this type as a pointer to it, e.g. `Display
*`. The same happens in `ash`, where `Display` is only ever referenced
as a raw pointer via `*mut Display`, so making `Display` itself a type
alias to `*mut c_void` is wrong and confusing. Switch it back to a
`c_void` to match the forward-declared (but otherwise undefined) `struct
_XDisplay`.
MarijnS95
force-pushed
the
platform-types-display-match-xlib
branch
from
6605992 to
ea5787f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #749
Xlib defines
Displayas follows:And then always references this type as a pointer to it, e.g.
Display *. The same happens inash, whereDisplayis only ever referenced as a raw pointer via*mut Display, so makingDisplayitself a type alias to*mut c_voidis wrong and confusing. Switch it back to ac_voidto match the forward-declared (but otherwise undefined)struct _XDisplay.