-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension wrapper for VK_KHR_synchronization2 #403
Add extension wrapper for VK_KHR_synchronization2 #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to see where to leave vkCmdWriteBufferMarker2AMD
and vkGetQueueCheckpointData2NV
.
Don't forget to add empty lines between the functions in synchronization2.rs
.
By the way, for all the functions returning void (()
) you might as well remove the trailing semicolon ;
. That way, if a return type is ever added to a function (or a function is copypasted to implement a new function) a missed return type is immediately a compiler error instead of just a #[must_use]
-not-used warning on the vk::Result
.
Unfortunately I myself have not been very consistent in doing so with previous submissions either.
Thanks!
Thanks for taking the time really helpful. For the present the |
@Caradhrass Thanks for your patience, as mentioned in #403 (comment) / #402 (comment) I have already been working on extending As non-collaborator I am not allowed to mark my own review comments as resolved; feel free to close everything that has to be fixed so that we have a clear overview of what is done. It remains to be seen what the best order is to merge all these PRs in; we can possibly get your solution in first including the wrapper for |
@Caradhrass are you available to discuss how to proceed? My plan is to take in #410 / #411 first to use updated Sounds good? |
Sure, just keep the synchronization2 part of this and I am happy. |
You've done an excellent job on the non-raw bindings so there's no reason to drop them nor change authorship 😀 I'll take care of rebasing this when the generator and flags are in, thanks! |
c813e71
to
20f4d7a
Compare
20f4d7a
to
d22fc11
Compare
I tried my best to implement Flag64 but i am not a rust god.