PR-3244 S3 credential fix #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reweeden
force-pushed
the
rew/pr-3244-s3-credential-fix
branch
from
de662fd to
f4a39ef
Compare
| if policy is None: | ||
| template_vars = { | ||
| "contentstring": "You do not have permission to access any data.", | ||
| "title": "Could not access data", |
There was a problem hiding this comment.
I don't think this really matters but it seems weird to have contentstring before title
There was a problem hiding this comment.
Yea, unfortunately this is the order it's in everywhere. I'd love to refactor this whole file and fix all sorts of stuff like this, but last time I tried to do that I got blocked because people didn't like that refactoring would cause additional commits to be created in the history...
| mock_make_html_response.assert_called_once_with( | ||
| { | ||
| "contentstring": "You do not have permission to access any data.", | ||
| "title": "Could not access data", |
There was a problem hiding this comment.
Again, a little weird
mckadesorensen
previously approved these changes
Oct 21, 2022
reweeden
force-pushed
the
rew/pr-3244-s3-credential-fix
branch
from
f4a39ef to
becb60d
Compare
mattp0
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix comes from updating the rain-api-core dependency to the version that will dedupe statement resources