Skip to content

Commit

Permalink
Merge pull request #60 from aserto-dev/go-1.23
Browse files Browse the repository at this point in the history
Update to go 1.23
  • Loading branch information
carabasdaniel authored Oct 10, 2024
2 parents 0132411 + a3a4819 commit a1c5263
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 24 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ on:
- main
- release-*
env:
GO_VERSION: "1.22"
GO_RELEASER_VERSION: "v1.24.0"
GO_LANGCI_LINT_VERSION: "v1.56.2"
GO_VERSION: "1.23"
GO_LANGCI_LINT_VERSION: "v1.61.0"
GO_TESTSUM_VERSION: "1.11.0"

jobs:
Expand Down
25 changes: 6 additions & 19 deletions .golangci.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
---
# golangci.com configuration
# https://github.com/golangci/golangci/wiki/Configuration
run:
timeout: 5m

linters-settings:
depguard:
Expand All @@ -16,7 +18,7 @@ linters-settings:
lines: 120
statements: 80
gci:
local-prefixes: github.com/golangci/golangci-lint
prefix: github.com/golangci/golangci-lint
goconst:
min-len: 2
min-occurrences: 2
Expand All @@ -39,17 +41,8 @@ linters-settings:
local-prefixes: github.com/golangci/golangci-lint
golint:
min-confidence: 0
gomnd:
settings:
mnd:
# don't include the "operation" and "assign"
checks:
- argument
- case
- condition
- return
govet:
check-shadowing: true
shadow: true
settings:
printf:
funcs:
Expand All @@ -74,8 +67,7 @@ linters:
- asciicheck
- bodyclose
- dogsled
- errcheck
- exportloopref
- errcheck
- exhaustive
- funlen
- gochecknoinits
Expand Down Expand Up @@ -152,9 +144,4 @@ issues:
- gocritic
- text: "G404"
linters:
- gosec

run:
timeout: 5m
skip-dirs:
- pkg/testharness/testdata
- gosec
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ module github.com/aserto-dev/runtime

go 1.21

toolchain go1.23.2

require (
github.com/aserto-dev/logger v0.0.6
github.com/fsnotify/fsnotify v1.7.0
Expand Down
6 changes: 4 additions & 2 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,17 @@ EXT_DIR := ./.ext
EXT_BIN_DIR := ${EXT_DIR}/bin
EXT_TMP_DIR := ${EXT_DIR}/tmp

GO_VER := 1.23
GOTESTSUM_VER := 1.11.0
GOLANGCI-LINT_VER := 1.56.2
GOLANGCI-LINT_VER := 1.61.0
WIRE_VER := 0.6.0

.DEFAULT_GOAL := test

.PHONY: deps
deps: info install-golangci-lint install-gotestsum install-wire
deps: info install-golangci-lint install-gotestsum install-wire
@echo -e "$(ATTN_COLOR)==> $@ $(NO_COLOR)"
@(go env GOVERSION | grep "go${GO_VER}") || (echo "go version check failed expected go${GO_VER} got $$(go env GOVERSION)"; exit 1)

.PHONY: generate
generate:
Expand Down

0 comments on commit a1c5263

Please sign in to comment.