Handle ResourceMapperError in AsertoAuthorizationManager.check #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #11.
ResourceMapper.getResource
may throw exceptions of typeResourceMapperError
butAsertoAuthorizationManager.check
doesn't handle those errors. The result is a 500 response.With this proposed change, the
AsertoAuthorizationManager
catches theResourceMapperError
, logs it, and returnsAuthorizationDecision(false)
to deny access.The ideal outcome when a request is made to a path that matches no routes would be a 404, but the authorization manager has no definitive way of determining the underlying cause of the
ResourceMapperError
and even if it did,@PreAuthorize
requires a boolean value so the only viable options are to either allow or deny the call.