Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only test on latest GitHub Runners #1438

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Jan 18, 2023

Summary

GitHub have deprecated the macOS 10.15 runner.

https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

I am not sure of the value we're getting here. I originally wanted to execute our tests on each version of a Runner just to be certain about what we support, but it is clear, given GitHubs eager deprecation of macOS 15.10 that it is largely pointless and just wasteful of general resources and our time (on small PRs).

Related:

Performance of macOS Runner is still very poor:

Our macos jobs consistently take 100%-300% more time to complete than ubuntu

Other Information

GitHub should provide an option for Runners which executes on all current supported runners so as they deprecate our pipelines change, ubuntu-all & macos-all 🤔 Immutability of that is probably bad.

@jthegedus jthegedus requested a review from a team as a code owner January 18, 2023 15:07
@jthegedus jthegedus merged commit 9a8bb47 into master Jan 18, 2023
@jthegedus jthegedus deleted the macOS_10_15-deprecated branch January 18, 2023 15:29
@jthegedus
Copy link
Contributor Author

Merging because I actually wanted to see results of my other PR that had a failure and GitHub threw a fit and it was possibly caused by a macos runner brown-out as with #1420 🙄

@Stratus3D
Copy link
Member

Thanks @jthegedus , I think this is the right choice for now, but I agree it was nice seeing the results for each runner OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants