Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: further notes on disabling plugin repo #1282

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Jun 29, 2022

Summary

This is a follow up to #1227 to document behaviours further as noted in #1227 (comment)

  • note that plugin_repository_last_check_duration does not stop initial repo sync
  • note that disable_plugin_short_name_repository does not remove the plugin repo if it has already been synced. Document how to remove the plugin repo if the user desires.
  • consolidate the ~/.asdfrc example file contents under the repo root defaults file and inline file itself.

Other Information

@jthegedus jthegedus requested a review from a team as a code owner June 29, 2022 12:12
@@ -1,2 +1,7 @@
# enables the use of .ruby-version like files used by other version managers
# See the docs for explanations: https://asdf-vm.com/manage/configuration.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a bit messy explaining each option here and then in-lining this file in the docs where we then explain what each setting does in more detail. Seemed a link to the docs was better, assuming network and web access. I am on the fence and can be convinced on reversing this change.

@jthegedus jthegedus merged commit 624aede into master Jun 30, 2022
@jthegedus jthegedus deleted the docs/configuration-plugin-repo-rework branch June 30, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants