Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow relative image urls for background placeholder #710

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

ashhitch
Copy link
Contributor

Currently if you use relative urls for the background placeholder (e.g with Netlify image CDN) you get an invalid background property: background:/.netlify/images

Checking if the background starts with / will resolve this.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for unpic-next ready!

Name Link
🔨 Latest commit 1e92908
🔍 Latest deploy log https://app.netlify.com/sites/unpic-next/deploys/67235c72f398b800087b495a
😎 Deploy Preview https://deploy-preview-710--unpic-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for unpic-angular ready!

Name Link
🔨 Latest commit 1e92908
🔍 Latest deploy log https://app.netlify.com/sites/unpic-angular/deploys/67235c72fb72340007680531
😎 Deploy Preview https://deploy-preview-710--unpic-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for unpic-docs ready!

Name Link
🔨 Latest commit 1e92908
🔍 Latest deploy log https://app.netlify.com/sites/unpic-docs/deploys/67235c72565eef0008651eab
😎 Deploy Preview https://deploy-preview-710.preview.unpic.pics
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic enabled auto-merge (squash) October 30, 2024 07:48
@ascorbic ascorbic merged commit 22c279c into ascorbic:main Oct 31, 2024
18 of 22 checks passed
@mixie-bot mixie-bot bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants