Support the Eclipse Java Compiler #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascopes
added
new feature
ascopes
force-pushed
the
task/ecj
branch
4 times, most recently
from
0e5a023 to
5335723
Compare
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage ? 88.60%
=======================================
Files ? 97
Lines ? 3046
Branches ? 241
=======================================
Hits ? 2699
Misses ? 298
Partials ? 49
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
ascopes
force-pushed
the
task/ecj
branch
4 times, most recently
from
1beb52f to
320bd22
Compare
|
This is now blocked by the following bug I have opened with ECJ: eclipse-jdt/eclipse.jdt.core#958 |
ascopes
force-pushed
the
task/ecj
branch
2 times, most recently
from
70b3669 to
b6c61bd
Compare
ascopes
force-pushed
the
task/ecj
branch
4 times, most recently
from
39347a8 to
346747c
Compare
|
Appears 3.34.0 of ECJ no longer supports Java 11. This will be an additional problem that will need to be worked around. |
ascopes
changed the title
ascopes
force-pushed
the
task/ecj
branch
2 times, most recently
from
f2e0721 to
f6aa0d8
Compare
ascopes
force-pushed
the
task/ecj
branch
3 times, most recently
from
d84b758 to
c686847
Compare
Implement a ForwardingJctFileManager to use for aggregation/delegation Add EcjJctFlagBuilderImpl for ECJ integration Implement EcjJctCompilerImpl and requried components Implement .newEcjCompiler() static method in JctCompilers class Implement EcjCompilerTest annotation and provider. Set 'since' attributes to 'TBC' for ECJ features Enable EcjCompilerTest on BasicLegacyCompilationIntegrationTest Enable EcjCompilerTest on BasicModuleCompilationIntegrationTest Add placeholders for EcjCompilerTest on BasicMultiModuleCompilationIntegrationTest This is currently marked as disabled due to buggy behaviour for MODULE_SOURCE_PATH locations in ECJ. Enable ECJ for CompilingSpecificClassesIntegrationTest Enable MultiTieredCompilationIntegrationTest for ECJ This is currently failing due to an integration issue with the classpath. Bump ECJ from 3.30.0 to 3.33.0 Tidy up modified integration tests Fix classpath lookups for ECJ when package names are slash-delimited Fix PathWrappingContainerImpl logs Output compiler verbose log messages to stderr rather than stdout Enable ECJ in Avaje Inject tests Add script to programmatically invoke ECJ Enable -XprintProcessorInfo and -XprintRounds when .verbose(true) on ECJ compilers Set minimum ECJ release version to JDK 8 rather than JDK 11.
|
Per eclipse-jdt/eclipse.jdt.core#1153, it appears ECJ will no longer support Java 11, meaning any changes needed to fix outstanding issues and bugs we are seeing will not be supported on Java 11 if/when they are considered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses GH-163, reintegrating ECJ into the framework.