-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nullish coalescing演算子(??
)とOptional chaining(?.
)
#1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Jul 5, 2020
Deploy preview for js-primer ready! Built with commit 82e7c9b |
azu
commented
Jul 5, 2020
azu
commented
Jul 13, 2020
結構operator周りを書き直してる。
|
azu
commented
Jul 19, 2020
@@ -40,7 +40,7 @@ describe("SUMMARY", function() { | |||
// 許可リスト(読み方の解説など) | |||
const allowFilePathList = []; | |||
const searchPatterns = ["/falsy/gi"]; | |||
const falsyChapter = path.join(sourceDir, "basic/implicit-coercion/README.md"); | |||
const falsyChapter = path.join(sourceDir, "basic/operator/README.md"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
falsyをoperatorに移動したため、テストも移動。
falsyに0n も追加しないとだめか → 追加した |
azu
commented
Aug 22, 2020
|
とりあえずこれでひとまずマージしようかな |
azu
commented
Aug 29, 2020
マージします。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nullish coalescing演算子(
??
)とOptional chaining(?.
)に関する変更変更されたページ
変更点
0n
も falsy に追加 データ型とリテラル: BigInt(ES2020+) #445?.
)の解説を"オブジェクト"の章に追加??
)とOptional chaining(?.
)の組み合わせを説明??
)の解説を"演算子"の章に追加||
を??
に置き換え??
推奨気味に変更追加しなかったこと
??
)とOptional chaining(?.
)の組み合わせのパターン?.
)window.fn?.()
みたいなケースfix #1178
fix #1179