Special characters get double encoded in truffleruby

[mojavelinux]

When running on truffleruby, the to_mathml method double encodes special twice.

Consider the following input text:

(::AsciiMath.parse '+-x').to_mathml

This produces:

<math><mo>&amp;#xB1;</mo><mi>x</mi></math>

instead of the expected:

<math><mo>&#xB1;</mo><mi>x</mi></math>

It's possible this is a bug in truffleruby itself.

[eregon]

If TruffleRuby behaves differently than MRI, then it's most likely a bug in TruffleRuby.
Please report it to https://github.com/oracle/truffleruby/issues
A small reproducer is of course even better 😃

[pepijnve]

@eregon oracle/truffleruby#1545

@mojavelinux This one looks like an issue in Truffle itself. Only workaround I can come up with is to not use String.encode.

[mojavelinux]

@pepijnve Exactly what we needed to know. Thanks for filing the issue upstream!

@eregon While I discovered the issue in Asciidoctor, the stacktrace led to AsciiMath. So I filed the issue here to verify the source of the problem before we brought it to truffleruby. Thanks for the support!

[pepijnve]

@mojavelinux FYI, I dropped MRI 1.8 support as part of this change. Semver would require me to mark the gem as 2.0, but I'm not going to do that. 1.8 is sufficiently legacy that I hope this is a non issue for people...

[mojavelinux]

Fine by me. 👍

[pepijnve]

@mojavelinux And the builds are green! 1.0.8 should be ready to go on rubygems.org.

[mojavelinux]

Thanks @pepijnve! The upstream builds are now green too.