Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ripgrep instead of vscode findFiles #910

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

ggrossetie
Copy link
Member

Based on #909

  • Remove the cache (for now)
  • Ensure compatibility with VS code web

@ggrossetie
Copy link
Member Author

@alaindresse Could you please give it a try? I removed the cache because we don't have an invalidation mechanism in case a file is removed

@ggrossetie
Copy link
Member Author

On Windows it does not work:

Error: spawn d:\a\asciidoctor-vscode\asciidoctor-vscode\node_modules\@vscode\ripgrep\bin\rg.exe ENOENT

@ggrossetie
Copy link
Member Author

Might be a drive letter issue since rg.exe is correctly downloaded:

D:\a\asciidoctor-vscode\asciidoctor-vscode\node_modules\@vscode\ripgrep\bin
Error: spawn d:\a\asciidoctor-vscode\asciidoctor-vscode\node_modules\@vscode\ripgrep\bin\rg.exe ENOENT

Or a backslash/frontslash issue.

@ggrossetie ggrossetie force-pushed the ripgrep-compat-web branch 2 times, most recently from f8abad0 to 18cf3c1 Compare October 8, 2024 15:15
@alaindresse
Copy link
Contributor

@alaindresse Could you please give it a try? I removed the cache because we don't have an invalidation mechanism in case a file is removed

Just gave it a try. Seems to work fine. Thank you so much !

@ggrossetie ggrossetie merged commit 7366a04 into master Oct 9, 2024
2 checks passed
@ggrossetie ggrossetie deleted the ripgrep-compat-web branch October 9, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants