Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated asciidoc-kroki to 0.12.0 #390

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

mariotoffia
Copy link
Contributor

Hi again, I wonder if it is possible to release this - I understand that you don't want to make releases based on such as simple things that updating a reference.

However, there where a serious issue that @Mogztter has fixed in asciidoctor-kroki that we use as excalidraw diagrams. Now he has enabled so we may render larger diagrams and we do no longer need to go through generate svg from diagram and update the repo. Instead we may render our diagrams inline in the asciidoc document.

Currently I've distributed a self compiled version of your excellent asciidoctor-vscode plugin!

Cheers,
Mario :)

There are some other enhancement - see https://github.com/Mogztter/asciidoctor-kroki/releases/tag/v0.12.0

Security

  • Check Asciidoctor security level before reading or writing to disk. Please note that, preprocessing, kroki-fetch-diagram and kroki-plantuml-include are only available when safe mode is server or lower.

Bug fixes

Improvements

@anb0s
Copy link
Contributor

anb0s commented Mar 3, 2021

That would be good, because it will fix the issue #361 👍

@mariotoffia
Copy link
Contributor Author

@danyill or @joaompinto is there any chance that you do a release of this in a near future?

Cheers,
Mario :)

@joaompinto
Copy link
Contributor

Will do a release this weekend. Thanks for the contribution.

@joaompinto joaompinto merged commit d87d502 into asciidoctor:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants