Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-200 error codes separately #429

Closed

Conversation

sransara
Copy link
Contributor

@sransara sransara commented Aug 13, 2023

Closes: #430

Handle non-200 error codes separately to give more visibility when the server is having issues.

With this the error messages show something like:

Skipping mermaid block. GET https://... - server returns 500 status code

@ggrossetie
Copy link
Member

Thanks for your contribution.
Before we proceed, could you please open an issue to discuss why this change is needed? (i.e., in which case you are experiencing an odd behavior, what is the current behavior, what is the expected behavior...).

@sransara
Copy link
Contributor Author

@ggrossetie sure thing. I have created and linked the issue.

@ggrossetie
Copy link
Member

superseded by #432

@ggrossetie ggrossetie closed this Aug 13, 2023
@sransara sransara deleted the handle-non-200-seperately branch August 13, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help narrow down the causes when server responds with error
2 participants