Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #245 adding support for pikchr #262

Merged
merged 4 commits into from
May 27, 2021
Merged

Conversation

juracy
Copy link
Contributor

@juracy juracy commented May 26, 2021

No description provided.

@ggrossetie
Copy link
Member

Thanks @juracy for your contribution 🎉
I'm glad that you took care of this issue. Since this is your first contribution on this repository, feel free to share things that we can improve to make it easier to contribute.

Tests are failing but this is not related to your changes. I've deployed a new version of https://kroki.io (0.13.0) and I need to update the fixtures/assertions.

@ggrossetie
Copy link
Member

@juracy I fixed master and rebase your branch

test/test.spec.js Outdated Show resolved Hide resolved
@juracy
Copy link
Contributor Author

juracy commented May 27, 2021

Thanks @Mogztter, maybe a Contribution Guide may help new contributors...

And my original PR passed through lint check, but it isn't passing now with your changes ...

> standard src/**.js test/**.js

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /home/juracy/workspace/asciidoctor-kroki/test/test.spec.js:966:1: Expected indentation of 6 spaces but found 0.

test/test.spec.js Outdated Show resolved Hide resolved
@ggrossetie
Copy link
Member

Thanks @Mogztter, maybe a Contribution Guide may help new contributors...

OK 👍🏻

And my original PR passed through lint check, but it isn't passing now with your changes ...

Ooops my bad, I will fix it.

@ggrossetie ggrossetie merged commit 9f40a52 into asciidoctor:master May 27, 2021
@ggrossetie
Copy link
Member

And merged! Thanks again 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants