Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wavedrom-cli.CMD ignored in searching for wavedrom-cli on Windows 11 #459

Closed
metro69 opened this issue Apr 4, 2024 · 0 comments
Closed
Labels

Comments

@metro69
Copy link

metro69 commented Apr 4, 2024

In lib/asciidoctor-diagram/wavedrom/converter.rb, the code checks whether the found wavedrom ends in '-cli'.

On windows 11, source.find_command finds "wavedrom-cli.CMD". This is ignored in the check in line 38:

        if wavedrom.end_with?('-cli')

This results the code failing to convert.
By changing the check to the code below, the conversion successfully completes.

        if wavedrom.end_with?('-cli') || wavedrom.end_with?('-cli.CMD')

wavedrom version: 3.2.0
asciidoctor-diagram version: 2.3.0

MT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants