Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#98 Changed on_delete behaviour of API requests to CASCADE #101

Closed
wants to merge 2 commits into from
Closed

#98 Changed on_delete behaviour of API requests to CASCADE #101

wants to merge 2 commits into from

Conversation

maurice-g
Copy link

@maurice-g maurice-g commented Mar 12, 2018 •
edited
Loading

Make users deletable again, by changing on_delete from PROTECT to CASCADE. This means that when deleting a users, all corresponding API logs will also be removed. With PROTECT users were not deletable at all, until all corresponding API request logs were manually removed. See #98

@triat
Copy link
Contributor

triat commented Mar 12, 2018

I would set SET_NULL, I wouldn't want to lose data that can help me to know more about my API

@jemerick jemerick mentioned this pull request Mar 15, 2018
Merged
@avelis avelis closed this May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maurice-g @triat @avelis