More CMake changes and less warnings #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `juce_recommended_warning_flags` This otherwise builds with `-Wall -Wextra` which shows a lot of less- or unimportant warnings with the important ones lost inbetween, plus you can not supress warnings. - move recommended lto and config flags to public as per juce recomendation - fix a few warnings - update tuningui submodule In total this brings the 2k+ displayed warnings down to managable 28 which are a few deprecated-declarations and two unused values. - add configurable option to add or supress warnings to CMakeLists.txt turned on as an example for linux, which in this example supresses the remaining warnings while newly introduced warnings will error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
juce_recommended_warning_flagsThis otherwise builds with
-Wall -Wextrawhich shows a lot of less- or unimportantwarnings with the important ones lost inbetween, plus you can not supress warnings.
In total this brings the 2k+ displayed warnings down to managable 28
which are a few deprecated-declarations and two unused values.
turned on as an example for linux, which in this example supresses the remaining warnings
while newly introduced warnings will error.