Skip to content

Commit

Permalink
JUCE as a submodule
Browse files Browse the repository at this point in the history
The cmake addition is great (thanks @showlabor)!
I'd like to suggest making JUCE a submodule though.

The way it is included via CPM now means it downloads around 250Mb
every time a new build folder is created or JUCE gets updated.
Adding it as a submodule with depth1 you end up with aprox 60Mb once,
updates are incremental and it's independent from the build folder.

This will also speed up potential pipeline builds.
  • Loading branch information
haenkel committed Apr 4, 2022
1 parent 22f03ad commit e78a8ad
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 1,045 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@
[submodule "libs/surgesynthteam_tuningui"]
path = libs/surgesynthteam_tuningui
url = https://github.com/surge-synthesizer/surgesynthteam_tuningui.git
[submodule "libs/JUCE"]
path = libs/JUCE
url = https://github.com/juce-framework/JUCE.git
Loading

0 comments on commit e78a8ad

Please sign in to comment.