Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bower.json's main to conform to Bower's spec. #57 #58

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

pmowrer
Copy link
Contributor

@pmowrer pmowrer commented Dec 17, 2014

Fixes #57

  • Update bower.json's main to conform to Bower's spec. Per https://github.com/bower/bower.json-spec, "main" should "not include minified files."
  • Replace ng-clip.js symlink with actual file. Necessary in order for ng-clip.js to come down when fetched via Bower.

@asafdav
Copy link
Owner

asafdav commented Dec 17, 2014

Hi, thanks for this pull request.

Please note that dist/ng-clip.js is created by Grunt and therefor there's no point of manually replacing it. feel free to update the Gruntfile accordingly.

@pmowrer
Copy link
Contributor Author

pmowrer commented Dec 17, 2014

Hi @asafdav! Sure, I can update bower.json to point to src/ngClip.js directly. I wasn't sure what the intention of the symlink was but I think I get it now.

asafdav added a commit that referenced this pull request Dec 17, 2014
Update bower.json's main to conform to Bower's spec. #57
@asafdav asafdav merged commit 6f8286e into asafdav:master Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bower.json "main" incorrectly (per spec) points to minified version
2 participants