Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Error hanlder #66

Open
andrzejWilde opened this issue Mar 17, 2015 · 3 comments
Open

No Error hanlder #66

andrzejWilde opened this issue Mar 17, 2015 · 3 comments

Comments

@andrzejWilde
Copy link

Hey, there's no error handler which makes using the lib quite difficult.

@levithomason
Copy link
Collaborator

Agreed, just spent a fair amount time debugging because the path the to the swf was wrong:

ngClipProvider.setPath('/bower_components/zeroclipboard/dist/ZeroClipboard.swf');

In this case, the bower install location changed from /app/bower/ to the usual location. Everything but this module worked. I'd be willing to help with some PRs if @asafdav is still planning on maintaining this module.

The only indication I had was that my cpu began to peg and the fans turned on :P

@asafdav
Copy link
Owner

asafdav commented Jun 24, 2015

Hi, I'm am planning to maintain this lib, what kind of PR would you like to
propose ?

On Wed, Jun 24, 2015 at 8:01 AM, Levi Thomason [email protected]
wrote:

Agreed, just spent a fair amount time debugging because the path the to
the swf was wrong:

ngClipProvider.setPath('/bower_components/zeroclipboard/dist/ZeroClipboard.swf');

In this case, the bower install location changed from /app/bower/ to the
usual location. Everything but this module worked. I'd be willing to help
with some PRs if @asafdav https://github.com/asafdav is still planning
on maintaining this module.

The only indication I had was that my cpu began to peg and the fans turned
on :P


Reply to this email directly or view it on GitHub
#66 (comment).

@levithomason
Copy link
Collaborator

Currently, when something goes wrong there is no indication of where to look or what went wrong.

Perhaps one place to start could be bundling the dependency so the user doesn't have to point to the SWF. Another option might be throwing an error if the SWF is not found at the location specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants