Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make excpetions optional depending on build-time feature checks. #162

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

chuim
Copy link
Contributor

@chuim chuim commented Sep 30, 2020

Replaces all try/catch/throw keyword usage with a set of macros that are
appropriately defined in config.hpp based on the status of the
cxx_exceptions compiler feature.

Reported in issue #160.

Replaces all try/catch/throw keyword usage with a set of macros that are
appropriately defined in config.hpp based on the status of the
`cxx_exceptions` compiler feature.

Reported in issue arximboldi#160.
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #162 into master will decrease coverage by 0.02%.
The diff coverage is 80.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   94.15%   94.12%   -0.03%     
==========================================
  Files         103      103              
  Lines       10002    10011       +9     
==========================================
+ Hits         9417     9423       +6     
- Misses        585      588       +3     
Impacted Files Coverage Δ
immer/detail/util.hpp 78.43% <0.00%> (ø)
immer/heap/gc_heap.hpp 81.81% <0.00%> (ø)
immer/heap/malloc_heap.hpp 83.33% <0.00%> (ø)
test/map/generic.ipp 100.00% <ø> (ø)
test/vector/generic.ipp 99.63% <ø> (ø)
immer/detail/arrays/with_capacity.hpp 88.72% <9.09%> (ø)
immer/detail/arrays/no_capacity.hpp 89.85% <20.00%> (ø)
immer/detail/arrays/node.hpp 91.89% <50.00%> (ø)
immer/detail/rbts/node.hpp 95.80% <81.25%> (ø)
immer/detail/hamts/node.hpp 96.86% <88.46%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2076aff...5316140. Read the comment docs.

immer/config.hpp Show resolved Hide resolved
Copy link
Owner

@arximboldi arximboldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Have you run clang-format on it?

@arximboldi
Copy link
Owner

Cool, thanks! I think the last incarnation is acceptable. Merging!

@arximboldi arximboldi merged commit 21f1280 into arximboldi:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants