Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phabricator support to git submit #840

Merged
merged 8 commits into from
Mar 12, 2023
Merged

Add Phabricator support to git submit #840

merged 8 commits into from
Mar 12, 2023

Commits on Mar 12, 2023

  1. cleanup(build): sort some dependencies

    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    ed2c111 View commit details
    Browse the repository at this point in the history

  2. cleanup(submit): enable standard lint diagnostics for `git-branchless… 

    …-submit`
    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    84d586e View commit details
    Browse the repository at this point in the history

  3. feat(submit): create BranchPushForge 

    The idea being to create other "forges", representing Git hosting providers, that can be pushed to in ways that support code review workflows.
    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    fb22b0a View commit details
    Browse the repository at this point in the history

  4. refactor(repo): make Commit::get_message* functions infallible

    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    2c4dea7 View commit details
    Browse the repository at this point in the history

  5. feat(test): expose head_commit_oid 

    The intention is to use this after Phabricator's `arc diff` amends the current commit's message, so that we can adopt the resulting message.
    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    4971d5e View commit details
    Browse the repository at this point in the history

  6. feat(submit): create Phabricator forge

    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    5a8f198 View commit details
    Browse the repository at this point in the history

  7. feat(submit): automatically create branches after git submit --create 

    (Only if the branches don't already exist.)
    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    eddef82 View commit details
    Browse the repository at this point in the history

  8. feat(test): adjust some wording to say "command" instead of "test" 

    Since we also use the testing infrastructure to submit to Phabricator, it's inaccurate to say "test" in many of these places. (jj also plans to use `jj run` instead of `jj test`.)
    @arxanas
    arxanas committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    40ba072 View commit details
    Browse the repository at this point in the history