Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/1] feat(submit:github): implement Github forge #1184

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

arxanas
Copy link
Owner

@arxanas arxanas commented Jan 7, 2024

Stack:


feat(submit:github): implement Github forge

  • It's not very good. It's probably buggy since there's a huge amount of state to keep in sync between commits, branches, and pull requests.
  • It's not very useful. When using Github's "Rebase and merge" button, it always rewrites the commit to update the committer signature. Then, for some reason, descendant commits can't be rebased automatically, and you have to manually rebase them.

@arxanas arxanas changed the title feat(submit:github): implement Github forge [1/1] feat(submit:github): implement Github forge Jan 7, 2024
@arxanas arxanas force-pushed the arxanas/feat-submit-github-implement-github-forge branch from 71121bd to 85beba8 Compare January 8, 2024 00:05
@arxanas arxanas force-pushed the arxanas/feat-submit-github-implement-github-forge branch from 85beba8 to 9aacc6f Compare February 11, 2024 21:21
@arxanas arxanas changed the title [1/1] feat(submit:github): implement Github forge [2/2] feat(submit:github): implement Github forge Feb 11, 2024
@arxanas arxanas changed the base branch from master to arxanas/testing-forward-rust-log-environment-variable February 11, 2024 23:41
@arxanas arxanas force-pushed the arxanas/feat-submit-github-implement-github-forge branch from 9aacc6f to 6ccb948 Compare February 11, 2024 23:41
Base automatically changed from arxanas/testing-forward-rust-log-environment-variable to master February 12, 2024 00:01
@arxanas arxanas marked this pull request as ready for review February 27, 2024 22:30
@arxanas arxanas force-pushed the arxanas/feat-submit-github-implement-github-forge branch from 6ccb948 to b32eb42 Compare February 27, 2024 22:30
- It's not very good. It's probably buggy since there's a huge amount of state to keep in sync between commits, branches, and pull requests.
- It's not very useful. When using Github's "Rebase and merge" button, it always rewrites the commit to update the committer signature. Then, for some reason, descendant commits can't be rebased automatically, and you have to manually rebase them.
@arxanas arxanas force-pushed the arxanas/feat-submit-github-implement-github-forge branch from b32eb42 to e591fa3 Compare February 27, 2024 22:38
@arxanas arxanas changed the title [2/2] feat(submit:github): implement Github forge [1/1] feat(submit:github): implement Github forge Feb 27, 2024
@arxanas arxanas merged commit e7c3653 into master Feb 28, 2024
26 checks passed
@arxanas arxanas deleted the arxanas/feat-submit-github-implement-github-forge branch February 28, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant