Make quartile_int a class #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, it seems to need to rebase as there are unrelated commits in this PR. |
rohanbabbar04
force-pushed
the
quartile_int
branch
from
c21e4ec
to
cf1c10d
Compare
Fixed that, now should include commits for this PR |
|
Have you tried the function yourself? |
aloctavodia
reviewed
Oct 27, 2024
| @@ -373,6 +373,7 @@ def fit_to_sample(selected_distributions, sample, x_min, x_max): | |||
|
|
|||
| def fit_to_quartile(dist_names, q1, q2, q3, extra_pros): | |||
| error = np.inf | |||
| fitted_dist = None | |||
There was a problem hiding this comment.
in case we are not able to fit a thing (for instance a domain error)
| self._q1 = q1 | ||
| self._q2 = q2 | ||
| self._q3 = q3 | ||
| self.dist = None |
There was a problem hiding this comment.
we need to store the distribution that we fit, this is the main reason for this refactor
| self.dist = fitted_dist | ||
|
|
||
| def _setup_observers(self): | ||
| def _match_distribution_(_): |
There was a problem hiding this comment.
we need to do this so we can call the function each time parameters change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #547
QuartileIntclassChecklist