Minor changes suggested

arviz-devs · Jan 19, 2025 · 5174e4f · 5174e4f
1 parent 469be83
commit 5174e4f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/preliz/distributions/chi_squared.py b/preliz/distributions/chi_squared.py
@@ -92,7 +92,7 @@ def mean(self):
         return self.nu
 
     def mode(self):
-        return max(self.nu - 2, 0)
+        return np.maximum(self.nu - 2, 0)
 
     def median(self):
         return self.ppf(0.5)

diff --git a/preliz/distributions/discrete_uniform.py b/preliz/distributions/discrete_uniform.py
@@ -101,7 +101,7 @@ def mean(self):
         return (self.upper + self.lower) / 2
 
     def mode(self):
-        return np.nan
+        return (self.upper + self.lower) / 2
 
     def median(self):
         return np.floor((self.upper + self.lower) / 2)

diff --git a/preliz/distributions/kumaraswamy.py b/preliz/distributions/kumaraswamy.py
@@ -95,7 +95,7 @@ def mean(self):
 
     def mode(self):
         return np.where(
-            (self.a > 1) & (self.b > 1), ((self.a - 1) / (self.a * self.b - 1)) ** (1 / self.a), 1
+            (self.a > 1) | (self.b > 1), ((self.a - 1) / (self.a * self.b - 1)) ** (1 / self.a), 0.5
         )
 
     def median(self):

diff --git a/preliz/distributions/truncatednormal.py b/preliz/distributions/truncatednormal.py
@@ -124,7 +124,7 @@ def mean(self):
         )
 
     def mode(self):
-        return max(self.lower, min(self.upper, self.mu))
+        return np.maximum(self.lower, np.minimum(self.upper, self.mu))
 
     def median(self):
         alpha = (self.lower - self.mu) / self.sigma

diff --git a/preliz/distributions/wald.py b/preliz/distributions/wald.py
@@ -139,7 +139,7 @@ def mean(self):
 
     def mode(self):
         return self.mu * (
-            (1 + (9 * self.mu**2) / (4 * self.lam**2)) ** 0.5 - 3 * self.mu / 2 * self.lam
+            (1 + (9 * self.mu**2) / (4 * self.lam**2)) ** 0.5 - (3 * self.mu) / (2 * self.lam)
         )
 
     def median(self):