Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and extend idata.map docs #1255

Merged
merged 2 commits into from
Jun 20, 2020
Merged

fix and extend idata.map docs #1255

merged 2 commits into from
Jun 20, 2020

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jun 20, 2020

Description

Fix #1251, maybe #1252 too?

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

Copy link
Contributor

@kyleabeauchamp kyleabeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyleabeauchamp
Copy link
Contributor

FWIW, did you confirm that the docs build locally?

@OriolAbril
Copy link
Member Author

FWIW, did you confirm that the docs build locally?

Yes, here is a screenshot

image

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #1255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1255   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          98       98           
  Lines        9715     9715           
=======================================
  Hits         9046     9046           
  Misses        669      669           
Impacted Files Coverage Δ
arviz/data/inference_data.py 80.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6971e71...8abe43f. Read the comment docs.

@OriolAbril OriolAbril merged commit 965b971 into master Jun 20, 2020
@OriolAbril OriolAbril deleted the idata_map branch June 20, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InferenceData.map docstring examples are broken in docs
2 participants