Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix applying IP filter to DHT traffic (HanabishiRecca) #7829

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Jan 25, 2025

adresses #7789

@HanabishiRecca
Copy link
Contributor

I want to mention again that this patch does not block the interaction with banned IPs completely. It's more a partial workaroud.

dht_tracker itself simply lacks any filtering logic. I.e. incoming_packet() still accepts all incoming traffic, send_packet() still communicates with a banned peer when it manages to make it into the DHT node list somehow.

@arvidn
Copy link
Owner Author

arvidn commented Jan 25, 2025

right, makes sense

@arvidn arvidn merged commit 7de186f into RC_2_0 Jan 26, 2025
42 checks passed
@arvidn arvidn deleted the dht-ip-filter branch January 26, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants