Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cibuildwheel: update workflow #7805

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

xavier2k6
Copy link
Contributor

@xavier2k6 xavier2k6 commented Dec 2, 2024

  • Bumped cibuildwheel action
  • Removed macos-12 runner (deprecated)
  • Updated Boost Download URL
  • Used more appropriate OS Runners for required jobs (architecure specific)
  • Explicitly declare each cibuildwheel identifier

@xavier2k6
Copy link
Contributor Author

@qstokkink I've done a dry-run for all python versions from python 3.9+ across all builds so that the tribler team can test/use them especially for requested macOS 12 prior to it's imminent deprecation/removal as a GH runner image. (Today - 3rd Dec is it's deadline....)

I plan on removing macos-12 when it's completely unavailable as a GH runner image from this PR.

@qstokkink
Copy link

@xavier2k6 Thanks 🙏 I had hoped for a PyPI release before the deadline, but I guess that wasn't in the cards.

@xavier2k6 xavier2k6 force-pushed the wheel_macos12_depr branch 4 times, most recently from 7cc8b3b to 87d40fd Compare January 7, 2025 23:07
@xavier2k6 xavier2k6 changed the title Update cibuildwheel.yml cibuildwheel: update workflow Jan 18, 2025
@xavier2k6
Copy link
Contributor Author

I plan to do a re-base/one final change after your macos fixes are in-place.....unsure of why windows-2025 is failing & don't really have time to look into it. (will more than likely revert to windows-latest which is currently = windows-2022)

@arvidn arvidn closed this Jan 24, 2025
@arvidn arvidn reopened this Jan 24, 2025
@@ -126,7 +160,7 @@ jobs:
vcpkg install openssl:x86-windows
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the condition for this job needs to be updated to also cover CIBW_BUILD ending with "win_amd64"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe instead look at whether os starts with "windows-"

Copy link
Contributor Author

@xavier2k6 xavier2k6 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The win_amd64 build had no issues previously with windows-2022...I'll think I'll just revert to that as the windows-2025 image is still classed as beta & there are still tools etc. been added/updated. (will look in to using it again in a few weeks when v3 of cibuildweel action is released.)

Could also look at updating (manylinux) to build with FORTIFY_SOURCE=3 instead of 2

Is that ok with you??

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase/make changes in about an hour or so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on sync? -> #7805 (comment)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavier2k6
Copy link
Contributor Author

@arvidn re-based & as you can see both manylinux builds are passing.....should I add the manylinux script changes here too or do you want to do your own thing?

@arvidn
Copy link
Owner

arvidn commented Jan 26, 2025

CI seems very finicky when changing these things. so any green CI I think should land without mixing in additional risks of all the errors I've seen in the other PR

@xavier2k6 xavier2k6 marked this pull request as ready for review January 26, 2025 18:14
@arvidn arvidn merged commit 91448ac into arvidn:RC_2_0 Jan 26, 2025
54 checks passed
@arvidn
Copy link
Owner

arvidn commented Jan 26, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants