don't discard netlink messages for previously seen addresses #7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses can come and go. Supressing notifications for previously seen addresses can cause the client to miss when the address is re-added. New address notifications also don't necessarily include an IFA_LOCAL attribute so don't filter on that either. Note that notifications don't cause all listen sockets to be closed and re-opened. Despite its name reopen_listen_sockets only closes/opens sockets as necessary to synchronize with the list of addresses enumerated from the OS.
|
For a while I've noticed that sometimes when my machine reboots the torrent client doesn't listen on IPv6. Restarting the client always fixes it so I suspected it had to do with address change notifications. I finally got around to investigating and found that all of the netlink notifications were being ignored due to these checks. |
arvidn
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses can come and go. Supressing notifications for previously seen addresses can cause the client to miss when the address is re-added. New address notifications also don't necessarily include an IFA_LOCAL attribute so don't filter on that either. Note that notifications don't cause all listen sockets to be closed and re-opened. Despite its name reopen_listen_sockets only closes/opens sockets as necessary to synchronize with the list of addresses enumerated from the OS.