Clean up MSVC compiler flags #7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control of multi-core compilation should be set at the build tool (e.g. MSBuild, ninja, make) and not as a compiler flag. Also cmake already append it automatically: https://github.com/Kitware/CMake/blob/e75afeae5cc1b41e1fb97e1924e6dbcd1e39d91a/CompileFlags.cmake#L118-L134
|
forward-port here: #7616 |
arvidn
approved these changes
Feb 18, 2024
clrpackages
pushed a commit
to clearlinux-pkgs/libtorrent-rasterbar
that referenced
this pull request
Feb 20, 2024
… to version 2.0.10
Calum Lind (1):
Bump boost version to enable Python 3.11 package builds
Christoph Reiter (1):
cmake: don't define _FILE_OFFSET_BITS on Windows
Hanabishi (1):
Restore file priorities in POSIX storage
Joris CARRIER (1):
allow execution of on_unknown_torrent method in the absence of active torrents
Lwxiang (2):
FIX(peer_list): clear the m_candidate_cache when clear peer_list, and set m_num_seeds to 0
TEST(peer_list): add clear_peers unittest for peer_list
Radu Carpa (2):
add set_ssl_certificate_buffer to python bindings
add ssl_listen_port to python bindings
Vladimir Golovnev (Glassez) (1):
Allow to change save path without moving any files
Vladimir Golovnev (glassez) (3):
Allow to change save path without any additional actions
Fix the wrong port is being announced to tracker
Reject resume data if it contains mismatching info hashes
Vort (1):
allow I2P leaseset encryption type 4
arvidn (35):
don't run win32 tests when building python wheel
fix missing python converter for dht::announce_flags_t
update SSL certificates for tests
Updated numerous repo addresses & revs of pre-commit-hooks. on behalf of @xavier2k6
suppress new GCC warning from 3rd party code (openssl)
update FreeBSD dependency on boost_build to boost-build
clang v16 (in combination with mingw-w64) has gotten stricter and now fails with: hidden visibility cannot be applied to 'dllexport' declaration
add python binding
add test
fix unnecessary capture of this in lambda expressions. and avoid implicitly capturing it, to conform to C++20
run thread-sanitizer on Ubuntu-22.04 on CI, to address https://bugs.launchpad.net/ubuntu/+source/gcc-10/+bug/2029910
bump clang version to 12
use GCC-12
fix warning
disable tsan warnings as errors
suppress false-positive warnings in GCC12
make sure the library builds with C++17 and C++20, in addition to C++14
also build python binding in linux.yml
rely on RVO in C++20
improve TORRENT_RVO feature detection
fix use of python ssl module
address issue in boost.asio building on iOS
improve checking and testing of max piece size
fix MingW64 CI build
fix assert in uTP resend_packet()
bump python version on github actions to 3.12
migrate away from aligned_storage
minor fixes
fix and suppress some new clang warnings util addressed (in master)
add test coverage for read_resume_data() when v1 or v2 hashes do not match the torrent metadata
fix test_copy_file for tmpfs
add missing test file to tarball
forward-port of arvidn/libtorrent#7615
recreate the SSL test certificates with long expiration time
bump version to 2.0.10
luzpaz (2):
Fixes various typos
README: Remove LGTM badges
sledgehammer999 (3):
Format CSS styles with Prettier
Lint CSS styles with Stylelint
Use Nord theme for dark theme
thrnz (1):
Schedule DHT announces using milliseconds rather than seconds.
xavier2k6 (3):
Remove obsolete LGTM config file
Update Cirrus CI config
Updated numerous pre-commit hook revs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170
Control of multi-core compilation should be set at the build tool (e.g. MSBuild, ninja, make) and not as a compiler flag.
Also cmake already append it automatically:
https://github.com/Kitware/CMake/blob/e75afeae5cc1b41e1fb97e1924e6dbcd1e39d91a/CompileFlags.cmake#L118-L134
This patch is for RC_1_2 and it should also be applied to RC_2_0 and master branch.