default built to require windows 10 #7602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier2k6
force-pushed
the
lbt_win10_default
branch
from
ad6a3b0 to
4ba0e06
Compare
xavier2k6
force-pushed
the
lbt_win10_default
branch
from
4ba0e06 to
f065163
Compare
arvidn
reviewed
Mar 16, 2024
src/drive_info.cpp
Outdated
| @@ -243,7 +243,7 @@ drive_info get_drive_info(std::string const& path) | |||
| if (dev.handle() == INVALID_HANDLE_VALUE) | |||
| continue; | |||
|
|
|||
| #if _WIN32_WINNT >= 0x601 | |||
There was a problem hiding this comment.
I don't understand this change. Is there anything in this block that requires windows 10?
xavier2k6
force-pushed
the
lbt_win10_default
branch
from
f065163 to
56020f0
Compare
arvidn
approved these changes
Mar 18, 2024
|
@arvidn I don't know how to fix the |
|
BTW, Boost are starting to |
|
it appears that having the build system define |
|
here's my attempt: #7662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.