Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebTorrent: Fix assert "p->connection == &c" #5915

Merged
merged 1 commit into from
Jan 26, 2021
Merged

WebTorrent: Fix assert "p->connection == &c" #5915

merged 1 commit into from
Jan 26, 2021

Conversation

paullouisageneau
Copy link
Contributor

@paullouisageneau paullouisageneau commented Jan 26, 2021 •
edited
Loading

This PR fixes an issue with peer_list::add_rtc_peer() which would override an already connected peer if allow_multiple_connections_per_ip is unset.

It fixes the assert fail p->connection == &c at src/peer_list.cpp:1176 (see #5100 (comment)).

For reference: #4123

@arvidn arvidn merged commit 206b04a into arvidn:master Jan 26, 2021
@paullouisageneau paullouisageneau deleted the fix-assert-connection branch March 9, 2021 09:21
@paullouisageneau paullouisageneau restored the fix-assert-connection branch March 9, 2021 09:21
@paullouisageneau paullouisageneau deleted the fix-assert-connection branch March 9, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullouisageneau @arvidn