WebTorrent: Update libdatachannel

[paullouisageneau]

This PR updates libdatachannel to v0.10.4. The modifications mainly affect media transport, but there is still some ICE enhancements and fixes in libjuice that can be useful here.

For reference: #4123

[arvidn]

Something happened on windows, causing usrsctp_import.lib to not be produced, or something like that.

Also, this error:

..\deps\libdatachannel\src\candidate.cpp(120): error C2220: the following warning is treated as an error
..\deps\libdatachannel\src\candidate.cpp(120): warning C4456: declaration of 'iss' hides previous local declaration
..\deps\libdatachannel\src\candidate.cpp(101): note: see declaration of 'iss'

[paullouisageneau]

Something happened on windows, causing usrsctp_import.lib to not be produced, or something like that.

The usrsctp lib was being built as a shared lib on MSVC. It should be good now.

[arvidn]

this is curious. I assume it's unrelated to this change:

../src/kademlia/dht_tracker.cpp:620:16: runtime error: signed integer overflow: 1810350180 + 715827882 cannot be represented in type 'int'

[arvidn]

there appears to be a use-after-free issue:

https://github.com/arvidn/libtorrent/pull/5884/checks?check_run_id=1737221565#step:7:109

[paullouisageneau]

this is curious. I assume it's unrelated to this change:

../src/kademlia/dht_tracker.cpp:620:16: runtime error: signed integer overflow: 1810350180 + 715827882 cannot be represented in type 'int'

That's weird, I don't see how the change could impact the DHT.

there appears to be a use-after-free issue:

https://github.com/arvidn/libtorrent/pull/5884/checks?check_run_id=1737221565#step:7:109

Yes, it appears a mitigation on usrsctp introduced a static delete order issue which is triggered here. Changing usrsctp versions definitely caused a lot of issues!

[arvidn]

the integer overflow is unrelated and addressed here.

[paullouisageneau]

Everything looks fixed now!